eddelbuettel / rcppsimdjson

Rcpp Bindings for the 'simdjson' Header Library
115 stars 13 forks source link

Feature/always int64 #55

Closed knapply closed 3 years ago

knapply commented 3 years ago

Addressing https://github.com/eddelbuettel/rcppsimdjson/issues/54.

@eddelbuettel, It also expands test coverage and makes some minor tweaks to existing ones as I needed to add tests for this anyways.

It's not remotely a rush - I just wanted to get it here while I'm still thinking about it.

codecov[bot] commented 3 years ago

Codecov Report

Merging #55 into master will increase coverage by 8.42%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   84.15%   92.58%   +8.42%     
==========================================
  Files          18       18              
  Lines        1218     1321     +103     
==========================================
+ Hits         1025     1223     +198     
+ Misses        193       98      -95     
Impacted Files Coverage Δ
inst/include/RcppSimdJson/deserialize/vector.hpp 96.87% <ø> (+0.20%) :arrow_up:
src/internal-utils.cpp 98.11% <ø> (+3.66%) :arrow_up:
R/fload.R 100.00% <100.00%> (+3.84%) :arrow_up:
R/fparse.R 100.00% <100.00%> (+3.57%) :arrow_up:
inst/include/RcppSimdJson/deserialize.hpp 86.78% <100.00%> (+23.21%) :arrow_up:
...t/include/RcppSimdJson/deserialize/Type_Doctor.hpp 100.00% <100.00%> (+4.60%) :arrow_up:
...nst/include/RcppSimdJson/deserialize/dataframe.hpp 97.80% <100.00%> (+27.80%) :arrow_up:
inst/include/RcppSimdJson/deserialize/matrix.hpp 100.00% <100.00%> (ø)
inst/include/RcppSimdJson/deserialize/simplify.hpp 100.00% <100.00%> (ø)
inst/include/RcppSimdJson/utils.hpp 98.75% <100.00%> (+2.45%) :arrow_up:
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b6117bd...95831a0. Read the comment docs.

eddelbuettel commented 3 years ago

Looks fab at a first glance. I'll try to come back to it in a day or two.