Closed knapply closed 3 years ago
Merging #57 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #57 +/- ##
=======================================
Coverage 94.28% 94.28%
=======================================
Files 17 17
Lines 1312 1312
=======================================
Hits 1237 1237
Misses 75 75
Impacted Files | Coverage Δ | |
---|---|---|
src/simdjson_example.cpp | 96.29% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f3dd32b...e89a8ea. Read the comment docs.
This codecov report, possibly related, makes little sense as it claims one line is missed. Huh? https://codecov.io/gh/eddelbuettel/rcppsimdjson/src/master/src/simdjson_example.cpp
Weird. I'll take care of it in the feature/simdjson-utils branch.
It could also be confused (in part) because we re-run covr
with each compiler which we really don't need to.
Workaround verified over here.
For completeness sake, you can reproduce the fit thrown by the compiler when
CXX17 = clang++-9
with the following:No issue w/ current CRAN
``` r Makevars <- readLines("/home/brendan/.R/Makevars") Makevars[grepl("^CXX17\\s{0,}=", Makevars)] #> [1] "CXX17 = clang++-9" install.packages("RcppSimdJson", version = "0.1.2") # current CRAN version #> Installing package into '/home/brendan/R/x86_64-pc-linux-gnu-library/4.0' #> (as 'lib' is unspecified) RcppSimdJson::fparse('{"Good to go?": true}') #> $`Good to go?` #> [1] TRUE ```Clang 9 throws a fit when installing from current GitHub master
``` r Makevars <- readLines("/home/brendan/.R/Makevars") Makevars[grepl("^CXX17\\s{0,}=", Makevars)] #> [1] "CXX17 = clang++-9" remotes::install_github("eddelbuettel/rcppsimdjson@f3dd32b1adf536cf011adc1f63895a423abcde27") # current master #> Using github PAT from envvar GITHUB_PAT #> Downloading GitHub repo eddelbuettel/rcppsimdjson@f3dd32b1adf536cf011adc1f63895a423abcde27 #> #> checking for file ‘/tmp/Rtmp0Qnsyc/remotes6a844056865/eddelbuettel-rcppsimdjson-f3dd32b/DESCRIPTION’ ... ✓ checking for file ‘/tmp/Rtmp0Qnsyc/remotes6a844056865/eddelbuettel-rcppsimdjson-f3dd32b/DESCRIPTION’ #> ─ preparing ‘RcppSimdJson’: #> checking DESCRIPTION meta-information ... ✓ checking DESCRIPTION meta-information #> ─ cleaning src #> ─ running ‘cleanup’ #> ─ installing the package to process help pages #> ----------------------------------- #> ─ installing *source* package ‘RcppSimdJson’ ... #> ** using staged installation #> ** setting up C++17 #> ** libs #> clang++-9 -std=gnu++17 -I"/usr/share/R/include" -DNDEBUG -I'/home/brendan/R/x86_64-pc-linux-gnu-library/4.0/Rcpp/include' -DSIMDJSON_NO_COMPUTED_GOTO -I../inst/include -fopenmp -fpic -g -O3 -march=native -c RcppExports.cpp -o RcppExports.o #> clang++-9 -std=gnu++17 -I"/usr/share/R/include" -DNDEBUG -I'/home/brendan/R/x86_64-pc-linux-gnu-library/4.0/Rcpp/include' -DSIMDJSON_NO_COMPUTED_GOTO -I../inst/include -fopenmp -fpic -g -O3 -march=native -c deserialize.cpp -o deserialize.o #> clang++-9 -std=gnu++17 -I"/usr/share/R/include" -DNDEBUG -I'/home/brendan/R/x86_64-pc-linux-gnu-library/4.0/Rcpp/include' -DSIMDJSON_NO_COMPUTED_GOTO -I../inst/include -fopenmp -fpic -g -O3 -march=native -c internal-utils.cpp -o internal-utils.o #> clang++-9 -std=gnu++17 -I"/usr/share/R/include" -DNDEBUG -I'/home/brendan/R/x86_64-pc-linux-gnu-library/4.0/Rcpp/include' -DSIMDJSON_NO_COMPUTED_GOTO -I../inst/include -fopenmp -fpic -g -O3 -march=native -c rcppsimdjson_utils_check.cpp -o rcppsimdjson_utils_check.o #> clang++-9 -std=gnu++17 -I"/usr/share/R/include" -DNDEBUG -I'/home/brendan/R/x86_64-pc-linux-gnu-library/4.0/Rcpp/include' -DSIMDJSON_NO_COMPUTED_GOTO -I../inst/include -fopenmp -fpic -g -O3 -march=native -c simdjson_example.cpp -o simdjson_example.o #> Stack dump: #> 0. Program arguments: /usr/lib/llvm-9/bin/clang -cc1 -triple x86_64-pc-linux-gnu -emit-obj -disable-free -disable-llvm-verifier -discard-value-names -main-file-name simdjson_example.cpp -mrelocation-model pic -pic-level 1 -mthread-model posix -fmath-errno -masm-verbose -mconstructor-aliases -munwind-tables -fuse-init-array -target-cpu skylake -target-feature +sse2 -target-feature +cx16 -target-feature +sahf -target-feature -tbm -target-feature -avx512ifma -target-feature -sha -target-feature -gfni -target-feature -fma4 -target-feature -vpclmulqdq -target-feature +prfchw -target-feature +bmi2 -target-feature 0. Program arguments: /usr/lib/llvm-9/bin/clang -cc1 -triple x86_64-pc-linux-gnu -emit-obj -disable-free -disable-llvm-verifier -discard-value-names -main-file-name simdjson_example.cpp -mrelocation-model pic -pic-level 1 -mthread-model posix -fmath-errno -masm-verbose -mconstructor-aliases -munwind-tables -fuse-init-array -target-cpu skylake -target-feature +sse2 -target-feature +cx16 -target-feature +sahf -target-feature -tbm -target-feature -avx512ifma -target-feature -sha -target-feature -gfni -target-feature -fma4 -target-feature -vpclmulqdq -target-feature +prfchw -target-feature +bmi2 -target-feature -cldemote -target-feature +fsgsbase -target-feature -ptwrite -target-feature +xsavec -target-feature +popcnt -target-feature +mpx -target-feature +aes -target-feature -avx512bitalg -target-feature -movdiri -target-feature +xsaves -target-feature -avx512er -target-feature -avx512vnni -target-feature -avx512vpopcntdq -target-feature -pconfig -target-feature -clwb -target-feature -avx512f -target-feature -clzero -target-feature -pku -target-feature +mmx -target-feature -lwp -target-feature -rdpid -target-feature -xop -target-feature +rdseed -target-feature -waitpkg -target-feature -movdir64b -target-feature -sse4a -target-feature -avx512bw -target-feature +clflushopt -target-feature +xsave -target-feature -avx512vbmi2 -target-feature +64bit -target-feature -avx512vl -target-feature +invpcid -target-feature -avx512cd -target-feature +avx -target-feature -vaes -target-feature +cx8 -target-feature +fma -target-feature -rtm -target-feature +bmi -target-feature -enqcmd -target-feature +rdrnd -target-feature -mwaitx -target-feature +sse4.1 -target-feature +sse4.2 -target-feature +avx2 -target-feature +fxsr -target-feature -wbnoinvd -target-feature +sse -target-feature +lzcnt -target-feature +pclmul -target-feature -prefetchwt1 -target-feature +f16c -target-feature +ssse3 -target-feature +sgx -target-feature -shstk -target-feature +cmov -target-feature -avx512vbmi -target-feature -avx512bf16 -target-feature +movbe -target-feature +xsaveopt -target-feature -avx512dq -target-feature +adx -target-feature -avx512pf -target-feature +sse3 -dwarf-column-info -debug-info-kind=limited -dwarf-version=4 -debugger-tuning=gdb -momit-leaf-frame-pointer -coverage-notes-file /tmp/RtmprltmKG/Rbuild6ade72e4a926/RcppSimdJson/src/simdjson_example.gcno -resource-dir /usr/lib/llvm-9/lib/clang/9.0.0 -I /usr/share/R/include -D NDEBUG -I /home/brendan/R/x86_64-pc-linux-gnu-library/4.0/Rcpp/include -D SIMDJSON_NO_COMPUTED_GOTO -I ../inst/include -internal-isystem /usr/bin/../lib/gcc/x86_64-linux-gnu/1 0. Program arguments: /usr/lib/llvm-9/bin/clang -cc1 -triple x86_64-pc-linux-gnu -emit-obj -disable-free -disable-llvm-verifier -discard-value-names -main-file-name simdjson_example.cpp -mrelocation-model pic -pic-level 1 -mthread-model posix -fmath-errno -masm-verbose -mconstructor-aliases -munwind-tables -fuse-init-array -target-cpu skylake -target-feature +sse2 -target-feature +cx16 -target-feature +sahf -target-feature -tbm -target-feature -avx512ifma -target-feature -sha -target-feature -gfni -target-feature -fma4 -target-feature -vpclmulqdq -target-feature +prfchw -target-feature +bmi2 -target-feature -cldemote -target-feature +fsgsbase -target-feature -ptwrite -target-feature +xsavec -target-feature +popcnt -target-feature +mpx -target-feature +aes -target-feature -avx512bitalg -target-feature -movdiri -target-feature +xsaves -target-feature -avx512er -target-feature -avx512vnni -target-feature -avx512vpopcntdq -target-feature -pconfig -target-feature -clwb -target-feature -avx512f -target-feature -clzero -target-feature -pku -target-feature +mmx -target-feature -lwp -target-feature -rdpid -target-feature -xop -target-feature +rdseed -target-feature -waitpkg -target-feature -movdir64b -target-feature -sse4a -target-feature -avx512bw -target-feature +clflushopt -target-feature +xsave -target-feature -avx512vbmi2 -target-feature +64bit -target-feature -avx512vl -target-feature +invpcid -target-feature -avx512cd -target-feature +avx -target-feature -vaes -target-feature +cx8 -target-feature +fma -target-feature -rtm -target-feature +bmi -target-feature -enqcmd -target-feature +rdrnd -target-feature -mwaitx -target-feature +sse4.1 -target-feature +sse4.2 -target-feature +avx2 -target-feature +fxsr -target-feature -wbnoinvd -target-feature +sse -target-feature +lzcnt -target-feature +pclmul -target-feature -prefetchwt1 -target-feature +f16c -target-feature +ssse3 -target-feature +sgx -target-feature -shstk -target-feature +cmov -target-feature -avx512vbmi -target-feature -avx512bf16 -target-feature +movbe -target-feature +xsaveopt -target-feature -avx512dq -target-feature +adx -target-feature -avx512pf -target-feature +sse3 -dwarf-column-info -debug-info-kind=limited -dwarf-version=4 -debugger-tuning=gdb -momit-leaf-frame-pointer -coverage-notes-file /tmp/RtmprltmKG/Rbuild6ade72e4a926/RcppSimdJson/src/simdjson_example.gcno -resource-dir /usr/lib/llvm-9/lib/clang/9.0.0 -I /usr/share/R/include -D NDEBUG -I /home/brendan/R/x86_64-pc-linux-gnu-library/4.0/Rcpp/include -D SIMDJSON_NO_COMPUTED_GOTO -I ../inst/include -internal-isystem /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10 -internal-isystem /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/x86_64-linux-gnu/c++/10 -internal-isystem /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/x86_64-linux-gnu/c++/10 -internal-isystem /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/backward -internal-isystem /usr/local/include -internal-isystem /usr/lib/llvm-9/lib/clang/9.0.0/include -internal-externc-isystem /usr/include/x86_64-linux-gnu -internal-externc-isystem /include -internal-externc-isystem /usr/include -O3 -std=gnu++17 -fdeprecated-macro -fdebug-compilation-dir /tmp/RtmprltmKG/Rbuild6ade72e4a926/RcppSimdJson/src -ferror-limit 19 -fmessage-length 0 -fopenmp -fobjc-runtime=gcc -fcxx-exceptions -fexceptions -fdiagnostics-show-option -vectorize-loops -vectorize-slp -faddrsig -o simdjson_example.o -x c++ simdjson_example.cpp #> 1.@lemire, in case you're wondering what this is about, I haven't been able to reproduce the problem with only C++ (with any clang version, or any C++ standard>=11) so I suspect it's an R-specific issue.