Closed knapply closed 3 years ago
Merging #58 into master will increase coverage by
1.66%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
+ Coverage 94.28% 95.95% +1.66%
==========================================
Files 17 18 +1
Lines 1312 1408 +96
==========================================
+ Hits 1237 1351 +114
+ Misses 75 57 -18
Impacted Files | Coverage Δ | |
---|---|---|
inst/include/RcppSimdJson/deserialize.hpp | 91.86% <ø> (+5.08%) |
:arrow_up: |
src/exported-utils.cpp | 100.00% <100.00%> (ø) |
|
src/simdjson_example.cpp | 100.00% <100.00%> (+3.70%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0a2537d...1108268. Read the comment docs.
Do you want to flip it from draft to genuine PR? Or are there more parts you think are missing?
Do you want to flip it from draft to genuine PR? Or are there more parts you think are missing?
Sure thing. I was just waiting for the CI to finish, but we should be good.
Which seems to start in slo-mo these days. [ And because I have more than $THRESHOLD repos I can't even auto-migrate to travis-ci.com. Rock, meet hard place. ]
Any reason not to fold this up and ship it to CRAN? (After one more round of win-builder / rhub of course.)
Nope, I can't think of anything.
Alrighty --merging and moving right along then.
Wrapped up and shipped to CRAN. Tickled a 'needs human review' because (I think) the Windows box has now GitHub PAT and hits link-access limits :crying_cat_face: as well as possibly to two existing build failures on the old box. I would expect it to fly through once they get to it, likely tomorrow (European hours) morning.
@eddelbuettel This is largely complete.
It adds
is_valid_utf8()
,is_valid_json()
, andfminify()
(I don't think there's a built-in way to do anfprettify()
at the moment).They're all vectorized (no more
vapply(json, jsonlite::validate, logical(1L))
!) and work oncharacter
s,raw
s, andlist
s ofraw
s.I need to step away and come back with fresh eyes, but all that should be needed is a fresh coat of paint on the documentation with some examples and to ensure the arguments are sufficiently validated (it's not quite as rigorous as
fload()
/fparse()
yet).Needless to say, the wizards working upstream have made everything obscenely fast...