codecov[bot]
commented
3 years ago Codecov Report
Merging #60 (e9f1a4a) into master (237449d) will increase coverage by
9.02%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
+ Coverage 87.11% 96.13% +9.02%
==========================================
Files 4 18 +14
Lines 194 1372 +1178
==========================================
+ Hits 169 1319 +1150
- Misses 25 53 +28 | Impacted Files | Coverage Δ | |
|---|---|---|
| R/fload.R | 100.00% <100.00%> (ø) |
|
| R/utils.R | 60.00% <100.00%> (+3.63%) |
:arrow_up: |
| inst/include/RcppSimdJson/deserialize/matrix.hpp | 100.00% <0.00%> (ø) |
|
| ...t/include/RcppSimdJson/deserialize/Type_Doctor.hpp | 100.00% <0.00%> (ø) |
|
| src/internal-utils.cpp | 100.00% <0.00%> (ø) |
|
| inst/include/RcppSimdJson/common.hpp | 100.00% <0.00%> (ø) |
|
| src/rcppsimdjson_utils_check.cpp | 100.00% <0.00%> (ø) |
|
| inst/include/RcppSimdJson/utils.hpp | 98.71% <0.00%> (ø) |
|
| inst/include/RcppSimdJson/deserialize/vector.hpp | 96.42% <0.00%> (ø) |
|
| inst/include/RcppSimdJson/deserialize.hpp | 91.74% <0.00%> (ø) |
|
| ... and 6 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 237449d...e9f1a4a. Read the comment docs.
Minor addition but review would be nice just to make sure we agree on style and naming, I don't want to rush it only to come back in a bit and go what were we thinking? ..., The functionality is lovely.
One related thought that came up: Running the request that drove this (for a market data 'quote' request from https://tiingo.com) reveals that resulting order in the returned object may be random. Which sucks for stacking or
rbind-ing data. Shall we add an option to may simply order columns by name? Or is this a 'best left to user' issue?data.tablehas an easysetcolorderthat is already cheap so I could live with that too, but it seems user-unfriendly at a glance...