simdjson 0.9.0 - Githubissues

eddelbuettel / rcppsimdjson

Rcpp Bindings for the 'simdjson' Header Library

115 stars 13 forks source link

simdjson 0.9.0 #69

Closed eddelbuettel closed 2 years ago

eddelbuettel commented 3 years ago

This seems related to #53 in that the on-demand API is now put to the fore (per the tweet announcement by @lemire).

Sadly, just copying the two singleheader/ files in as I attempted in a branch breaks our compilation in lots of places :cry:

lemire commented 3 years ago

@eddelbuettel We fully support the DOM API. I am sure it is only small stuff that fails.

lemire commented 3 years ago

Oh. I see. I will prepare a pull request.

lemire commented 3 years ago

I am working on a pull request. We effectively blocked what you are doing which is bypassing entirely the error handling. The way you did it is fine, I am sure, but people would bypassing checking the error and they complaining that they were getting garbage... so we are now forcing people to handle errors or to have exceptions.

People doing no error checking at all is a nightmare for us.

eddelbuettel commented 3 years ago

Thank you so much. @knapply is currently in transit but hopes to get a chance to look at it later today. There is not need to rush, I guess, as there are really two possible approaches

renable DOM we used / are using
change our code to on-demand (which we already planned by didn't get to yet), see #53

And latter one is, I guess, preferred by all but a little more work.

lemire commented 3 years ago

@eddelbuettel There is no need to reenable anything. You will see.

lemire commented 3 years ago

On Demand (https://github.com/eddelbuettel/rcppsimdjson/issues/53) would definitively be the way forward. It would enable really cool things and improve performance.

eddelbuettel commented 2 years ago

We have 1.0.0; the on-demand feature is still WIP and harder given R's memory interface...