Closed eddelbuettel closed 2 years ago
@eddelbuettel We fully support the DOM API. I am sure it is only small stuff that fails.
Oh. I see. I will prepare a pull request.
I am working on a pull request. We effectively blocked what you are doing which is bypassing entirely the error handling. The way you did it is fine, I am sure, but people would bypassing checking the error and they complaining that they were getting garbage... so we are now forcing people to handle errors or to have exceptions.
People doing no error checking at all is a nightmare for us.
Thank you so much. @knapply is currently in transit but hopes to get a chance to look at it later today. There is not need to rush, I guess, as there are really two possible approaches
And latter one is, I guess, preferred by all but a little more work.
@eddelbuettel There is no need to reenable anything. You will see.
On Demand (https://github.com/eddelbuettel/rcppsimdjson/issues/53) would definitively be the way forward. It would enable really cool things and improve performance.
We have 1.0.0; the on-demand feature is still WIP and harder given R's memory interface...
This seems related to #53 in that the on-demand API is now put to the fore (per the tweet announcement by @lemire).
Sadly, just copying the two
singleheader/
files in as I attempted in a branch breaks our compilation in lots of places :cry: