search

eddelbuettel / rcppsimdjson

Rcpp Bindings for the 'simdjson' Header Library
115 stars 13 forks source link

export .deserialize_json() #79

Closed shikokuchuo closed 1 year ago

shikokuchuo commented 1 year ago

PR for issue #78 to export .deserialize_json() with the most performant defaults.

eddelbuettel commented 1 year ago

Can you motivate the new function interface with timing evidence? As I mentioned and showed in the comment to your issue you can already call it (though not from another package, at least not directly, but you could play tricks).

The main question is: what speed difference are we talking about here?

eddelbuettel commented 1 year ago

Crikey NO:

image

The change you wanted to make in your PR was to undo the addition of two lines we do not need, NOT to delete the file we do need. git restore may do what you need.

shikokuchuo commented 1 year ago

Sorry I think we are back to where we were. Failed with the github GUI as I have multiple forks...

eddelbuettel commented 1 year ago

git is forgiving. You can git reset --hard to a know good place and start over. There is not that much worth keeping in the PR and as argued in https://github.com/eddelbuettel/rcppsimdjson/issues/78#issuecomment-1397777088 I am not sure we are spending our time wisely here.