eddelbuettel / rcppsimdjson

Rcpp Bindings for the 'simdjson' Header Library
115 stars 13 forks source link

Export deserialization function to both C++ and R (closes #80) #81

Closed eddelbuettel closed 1 year ago

eddelbuettel commented 1 year ago

This PR turns on exporting at the C++ and R level for the source file containing the deserialize_json internal workhorse function. No change at the R level, or how the package works internally, but simply offering other packages to utilize this.

Such cross-package use at the C(++) is currently not all that widely used but very powerful. We do not expect any side-effects based on similar use in another package.

codecov[bot] commented 1 year ago

Codecov Report

Base: 99.12% // Head: 99.12% // No change to project coverage :thumbsup:

Coverage data is based on head (e5544e9) compared to base (78a2233). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #81 +/- ## ======================================= Coverage 99.12% 99.12% ======================================= Files 18 18 Lines 1375 1375 ======================================= Hits 1363 1363 Misses 12 12 ``` | [Impacted Files](https://codecov.io/gh/eddelbuettel/rcppsimdjson/pull/81?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Dirk+Eddelbuettel) | Coverage Δ | | |---|---|---| | [src/deserialize.cpp](https://codecov.io/gh/eddelbuettel/rcppsimdjson/pull/81?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Dirk+Eddelbuettel#diff-c3JjL2Rlc2VyaWFsaXplLmNwcA==) | `100.00% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Dirk+Eddelbuettel). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Dirk+Eddelbuettel)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.