search

eddelbuettel / rcppsimdjson

Rcpp Bindings for the 'simdjson' Header Library
115 stars 13 forks source link

Bug in validate benchmark? #89

Closed anthonynorth closed 7 months ago

anthonynorth commented 7 months ago

There looks to be a bug in the validate json benchmark. {yyjsonr} is reading a file into memory instead of validating it.

https://github.com/eddelbuettel/rcppsimdjson/blob/7100cac4172e904171e8874563d21cbcd13938df/demo/simpleBenchmark.R#L19

I think this should be:

yyjsonr = yyjsonr::validate_json_file(file),
eddelbuettel commented 7 months ago

My bad, I will fix that.

eddelbuettel commented 7 months ago

Now done, thanks for catching that.