search

eddelbuettel / rcppsimdjson

Rcpp Bindings for the 'simdjson' Header Library
115 stars 13 forks source link

updating simdjson to 3.9.5 #92

Closed lemire closed 1 month ago

lemire commented 1 month ago

Fixes https://github.com/eddelbuettel/rcppsimdjson/issues/91

eddelbuettel commented 1 month ago

I don't remember from the top of my head whether I need manual mods but I think I don't so in in goes!

eddelbuettel commented 1 month ago

Thanks again -- this is now on CRAN after an extra day it took for a manual / one-off check against the newer g++.

eddelbuettel commented 1 month ago

@lemire I spoke too soon. Other email from Dortmund says

Thanks, we see: Fedora-gcc 14: Found the following significant warnings: ../inst/include/RcppSimdJson/deserialize/Type_Doctor.hpp:43:65: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor] Please fix and resubmit.

Can you take a look, time permitting, and suggest a change? I am currently fighting a different fire with Rcpp.

Update 1: ~Worst case, as mentioned, I could enforce C++17, at least for now.~ Apparently we already compile as C++17 so that is not an option.

Update 2: The fix may be reasonably simple. At least I have something that passes muster under g++-13.

Update 3: Now on CRAN.

lemire commented 1 month ago

Is there anything that needs to be done? The warning should be gone.

eddelbuettel commented 1 month ago

It's all good, I 'merely' had to remove the offending template-id in one ctor declaration on the R 'glue' side of the package.

The updated package (with simdjson 3.9.5) now on CRAN.