search

eddelbuettel / rcpptoml

Rcpp Bindings to C++ parser for TOML files
GNU General Public License v2.0
36 stars 9 forks source link

fix test of unicode support on Windows #39

Closed vh-d closed 5 years ago

vh-d commented 5 years ago

This should make the test of unicode support pass even on systems without UTF-8. Passes all tests on my Windows 7 system (set to Czech locale).

vh-d commented 5 years ago

There is another solution to this problem: adding an option to pass encoding= argument to parse() function in tinytest::test_package().

I find my solution with explicit hex representation more elegant but that feature for tinytest might be needed in the future anyway.

codecov[bot] commented 5 years ago

Codecov Report

Merging #39 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   59.71%   59.71%           
=======================================
  Files           3        3           
  Lines        1343     1343           
=======================================
  Hits          802      802           
  Misses        541      541

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b18fefb...8a9ecb1. Read the comment docs.

eddelbuettel commented 5 years ago

Nice one -- thanks.