search

eddelbuettel / rcppziggurat

Rcpp bindings for different Ziggurat RNG implementations
Other
12 stars 4 forks source link

add rcpp interface #17

Closed gkane26 closed 3 years ago

gkane26 commented 3 years ago

I added the line // [[Rcpp::interfaces(r, cpp) to ziggurat.cpp to access zrnorm in c++ code I am using for another rcpp package. I had to remove the dependency on RcppGSL to get this to work, but it looked like the RcppGSL package wasn't being used anyways?

eddelbuettel commented 3 years ago

As a general rule, I prefer the approach of first discussing in issue tickets what changes are contemplated over immediately dropping (somewhat invasive) PRs (touching seven files). And GSL is obviously being used as we compare to the GSL RNGs.

Now, I am aware that the transitive dependency on GSL stands in the way of a 'lighter' header-only use, and I have (on/off, lower priority) been thinking about this too. I don't think it can be done in the realm of this package so maybe one needs to spin up another micro package without GSL or vignette, To be seen.