search

eddelbuettel / rquantlib

R interface to the QuantLib library
119 stars 50 forks source link

CRAN suggests to address warnings #143

Closed eddelbuettel closed 4 years ago

eddelbuettel commented 4 years ago

KH in email points out that the results report the following:

Version: 0.4.10
Check: whether package can be installed
Result: WARN
    Found the following significant warnings:
     utils.cpp:79:37: warning: 'FDEuropeanEngine<QuantLib::CrankNicolson>' is deprecated [-Wdeprecated-declarations]
     utils.cpp:597:97: warning: 'Price' is deprecated [-Wdeprecated-declarations]
     utils.cpp:598:131: warning: 'Price' is deprecated [-Wdeprecated-declarations]
     utils.cpp:602:97: warning: 'Price' is deprecated [-Wdeprecated-declarations]
     utils.cpp:603:131: warning: 'Price' is deprecated [-Wdeprecated-declarations]
     vanilla.cpp:194:38: warning: 'FDDividendAmericanEngine<QuantLib::CrankNicolson>' is deprecated [-Wdeprecated-declarations]
     vanilla.cpp:225:38: warning: 'FDAmericanEngine<QuantLib::CrankNicolson>' is deprecated [-Wdeprecated-declarations]
Flavor: r-devel-linux-x86_64-debian-clang

Was aware, but had not looked closely enough and assumed it was upstream. Files utils.cpp and vanilla are however ours so will look at this more closely.