Closed jeroen closed 10 months ago
I see:
utils.cpp:651:24: error: use of undeclared identifier 'QL_PACKAGE_VERSION' 651 | return std::string(QL_PACKAGE_VERSION); | ^ 1 warning and 1 error generated.
It turns out when quantlib is built with cmake instead of autotools, the include/ql/config.hpp looks like so:
include/ql/config.hpp
#ifndef quantlib_config_h #define quantlib_config_h #define PACKAGE_NAME "QuantLib" #define PACKAGE_STRING "QuantLib 1.32.0" #define PACKAGE_TARNAME "QuantLib-1.32.0" #define PACKAGE_VERSION "1.32.0" #define PACKAGE_BUGREPORT "https://github.com/lballabio/QuantLib/issues/"
How irritating. Should we add another define / alias ? Or I guess I can handle it in utils.cpp conditionally.
That PR fixes it already
Yes that (sub-aspect too) is perfect.
I see:
It turns out when quantlib is built with cmake instead of autotools, the
include/ql/config.hpp
looks like so: