search

eddelbuettel / rquantlib

R interface to the QuantLib library
119 stars 50 forks source link

Extend curve building to 100 years #48

Closed tleitch closed 8 years ago

tleitch commented 8 years ago

Fork of master, modified, tested with R CMD check and travis

eddelbuettel commented 8 years ago

Looks good -- three commits, four files, clean diff that can be merged. One minor nag noted, you should be able to alter and push to this branch extending the PR to four commits.

We may be getting the hang of it :)

tleitch commented 8 years ago

Thanks.Note: two commits were artificially generated to trigger travis build for the first time. Are you suggesting there should be 1 commit per file?

eddelbuettel commented 8 years ago

No, I was just counting. Yes, each commit (and push) triggers a build (unless you add [ci skip] to the subject).

Tastes vary on whether many commits, or aggregated commits into one (ie "squashed") are better. Larger projects require squashed. A "handful" just like here is fine by me.

eddelbuettel commented 8 years ago

It's merged. If you declare my repo as an additional remote (the term 'parentrepo' is often used) then git pull --all will get updates from both, and can merge my changes (ie from your PR plus my merge commit) and push that back to your fork so that both are in sync.