search

eddelbuettel / rquantlib

R interface to the QuantLib library
119 stars 50 forks source link

Minor fixes in the help for FixedRateBond #5

Closed mzivi closed 10 years ago

mzivi commented 10 years ago

Fixed a typo in the help of FixedRateBond and added an example using the calculation based on yield

eddelbuettel commented 10 years ago

It looks like your pull request contains some old changes look included, eg https://github.com/mzivi/rquantlib/commit/f2c7b6157cf19576a9a496385cf5976697d85461 which you can compare to https://github.com/eddelbuettel/rquantlib/blob/master/inst/unitTests/runit.calendar.R

mzivi commented 10 years ago

yes sorry, I had fixed that typo in the test unit when we taked about it a couple of weeks ago and it got committed on my master, that's why it ended up there. But it's the same change that you did in 01a969ec66e60a5a86884c0c1fc485f0039bbe54 so it shouldn't change anything right? sorry for the noise.

eddelbuettel commented 10 years ago

I think if you merge with master, you should be able to generate a minimal set of differences for the pull request. (When I fork, I often set an explicit "parentrepo" of the upstream at github, you would then merge from parentrepo as well.)

eddelbuettel commented 10 years ago

On the plus side, 'files changed' only shows the help file so I will pull this in.

eddelbuettel commented 10 years ago

I think we should try to replicate a few examples from the QL unit tests and examples. We may have to write / add / alter a few more helper functions, but it would be good to replicate QL examples and tests.