eddelbuettel / rquantlib

R interface to the QuantLib library
119 stars 50 forks source link

Vol Cube reshape speed up #69

Closed tleitch closed 8 years ago

tleitch commented 8 years ago

Used assignInNamespace and reshape2 functions instead of for loops. No changes to library functions.

eddelbuettel commented 8 years ago

That looks fine but I don't quite understand why it is seven commits.

eddelbuettel commented 8 years ago

Conceptually speaking, and I do this all the time, we can do:

Cleaner?

eddelbuettel commented 8 years ago

I cherry-pick'ed the one commit that mattered from https://github.com/eddelbuettel/rquantlib/pull/69/commits/428b7ca67e4708035b8fab191eba8b875d70d1bd.