search

eddelbuettel / rquantlib

R interface to the QuantLib library
119 stars 50 forks source link

updated ChangeLog #7

Closed mzivi closed 10 years ago

mzivi commented 10 years ago

Sorry Dirk, I'll make sure I will update this going forward.

eddelbuettel commented 10 years ago

Looks great. But DESCRIPTION is wrong, as that is a file you hadn't touched. The rest is fine.

To you want me to merge and the fix, or do you want to send a follow-up commit?

mzivi commented 10 years ago

Sorry that's me being really dumb, somehow I thought of DESCRIPTION as a description of the change, not as the change in that file... Can you merge and fix please? Thanks

On Oct 29, 2014, at 9:57 PM, Dirk Eddelbuettel notifications@github.com wrote:

Looks great. But DESCRIPTION is wrong, as that is a file you hadn't touched. The rest is fine.

To you want me to merge and the fix, or do you want to send a follow-up commit?

— Reply to this email directly or view it on GitHub.

eddelbuettel commented 10 years ago

No worries. ChangeLog entries, just like many things, are a convention and it specified listing the file first. It is confusing when one such file is indeed called DESCRIPTION :)

I'll fix by hand.