search

eddes / AREP

code for comfort / optimization / IAQ
GNU General Public License v3.0
4 stars 6 forks source link

Variable "sex" is defined as both integer and string #1

Open kastnerp opened 2 years ago

kastnerp commented 2 years ago

Hi,

I looked at VDI_PET_corrected.py the other day and noticed that the variable sex is defined as both integer and string in lines 26 and 34 in as a global variable. Then, in lines 61 and line 179 if statements check the value of said variable which in line 179 will never be true. Has this been overlooked or is there something I am not aware of?

Best,

Patrick

eddes commented 2 years ago

Hi Patrick,

Thanks for your close review: this has indeed been overlooked (by then I was still beginning as a pythonist...). I will correct the typos.

Keep posted: the transient version of the PET will probably be uploaded in the coming weeks. There is roughly a discrepancy by one comfort category when comparing the transient SET with the steady-state PET (the code discussed above). Id est, when the SET says "Warm", the PET says "Very Warm" for identical ambient conditions (see our paper on indoor comfort at IBPSA 2021). All in all, it looks like we still have not gone through the meanders of the PET comfort index!

Regards, Edouard

kastnerp commented 2 years ago

Thanks and no problem of course. Looking forward to the new model!