search

eddex / hslu-simple-mep-results

:bar_chart: A browser add-on that adds essential features to the HSLU MyCampus website
MIT License
39 stars 16 forks source link

BA_GEST is not recognized as Zusatzmodul #50

Closed TheHuebschi closed 4 years ago

TheHuebschi commented 4 years ago

What do you study?

Which modules are not recognized by the add-on? And what type should they have?

Screenshots grafik

More info

eddex commented 4 years ago

Thanks for reporting this issue!

The problem is in the module_parser due to a conflict with other special cases where the module name contains an underscore:

https://github.com/eddex/hslu-simple-mep-results/blob/16363e06a5e9aa029151c790ecc2423e00935e0e/src/components/module_parser.js#L101

EDIT: The problem is not in the parser but in the parse_module_type.py script. The prefix 'BA_ has not been removed:

https://github.com/eddex/hslu-simple-mep-results/blob/16363e06a5e9aa029151c790ecc2423e00935e0e/tools/parse_module_type.py#L189