search

eddex / hslu-simple-mep-results

:bar_chart: A browser add-on that adds essential features to the HSLU MyCampus website
MIT License
39 stars 16 forks source link

Business IT modules missing and inconsistencies #69

Closed christofkaelin closed 3 years ago

christofkaelin commented 4 years ago

What do you study?

Which modules are not recognized by the add-on? And what type should they have?

Screenshots

WI_Modules

More info STA1, GPOR and WEBT all have a _K after their abbreviation. Possible way to differentiate them from their Erweiterungsmodul-Counterpart (?) Same goes for ISF, which seems to be a Kernmodul for Informatik, Wirtschaftsinformatik, ICS but an Erweiterungsmodul for the new AI course (see https://mycampus.hslu.ch/-/media/campus/common/files/dokumente/other/mycampus/i/dokumente-ausbildung/bachelor/modulbeschriebe-ics/information-security-fundamentals.pdf?la=de-ch)

Lextum commented 4 years ago

IPEUS, PIPE, TUNE, STO, FV those aren't on the official HSLU page. right?

Are you sure, you don't get credits for the TUTH1901? We parse the information from your MyCampus page and normally if a module has credits you should get them.

At the moment we only support I, WI and ICS. I will look into the AI course, shouldn't be to hard to add those modules.

christofkaelin commented 4 years ago

IPEUS and PIPE form together the International Project Experience in the Silicon Valley. You can find it here on MyCampus. TUNE, STO and FV are all ISA modules.

Regarding MAT1_TUT: AFAIK, the tutors receive credits for tutoring students. But as a participant I surely don't. On MyCampus it says "Ohne Modulabschluss" – maybe the tutors have a different status here?

MAT1
eddex commented 4 years ago

Should be fixed with #70. But we need to create a new release.

Lextum commented 4 years ago

Regarding MAT1_TUT: AFAIK, the tutors receive credits for tutoring students. But as a participant I surely don't. On MyCampus it says "Ohne Modulabschluss" – maybe the tutors have a different status here?

Could you check, if the credits are added to your total credits? When i'm not mistaken, they shouldn't.

christofkaelin commented 4 years ago

Could you check, if the credits are added to your total credits? When i'm not mistaken, they shouldn't.

That's right, they are not added to my total credits.

Suggestion: to make it less confusing, could you strikethrough the modules in the list which don't count towards the total?

Lextum commented 4 years ago

Could you check, if the credits are added to your total credits? When i'm not mistaken, they shouldn't.

That's right, they are not added to my total credits.

Suggestion: to make it less confusing, could you ~strikethrough~ the modules in the list which don't count towards the total?

I will look into it. Maybe we can do same CSS magic and give the users a better overview, which module counts and which isn't.

Lextum commented 4 years ago

I added strikethrough based on passed value. I'm not 100% sure if it covers every HSLU module status. Modules with 'successfully participated' is passed, module with 'attested' or 'enrolled' are unknown. Everything else will be striked out image

If you wanna help, you could test the changes. Just clone the repo, switch to the branch enhancement/markFailedModules and follow the source installation instructions in the README.md.

christofkaelin commented 4 years ago

Sure! To me it looks like this:

hslu-mycampus

Regarding the status of the ones that are striked through: MAREP is Teilgenommen erfüllt MAT1_TUT is Ohne Modulabschluss IPEUS is Bestätigt The others which are not striked through are either Erfolgreich teilgenommen or Testat erfüllt

Lextum commented 4 years ago

I wonder, do IPEUS and MAREP count against the credit total at the moment? Either my new commits have a logic flaw or we found another "bug" in the extension.