Breaking API changes break everything! Grades and Marks have been merged. Everything's broken!

[Lextum]

What would you like to change? [ Describe the current state and what you want to improve. ] ~~Remove the grade from the module table. Reason: HSLU changed every grade value to NULL. God knows why ;-)~~

Screenshots [ Put images or screenshots to better describe your idea here (if yoiu have some). ]

Contributing (please choose one) - [ ] I'd like to help implementing this change! - [ ] I don't have the time to work on this.

[eddex]

This is not a change request. It's a bug.

[eddex]

Describe the bug Right in time for the end of the semester, the API of the MyCampus website has been changed.

Previously there was always a grade (A-F) for all modules and a mark (6-1) for some of them. Now this has been changed. All modules only have a mark filed in the API response. This field contains the mark (6-1) but if there was no mark, it contains the grade (A-F). The grade doesn't just come in form of a single letter but also contains a description in text from.

Example: The grade (in the last column) is still in the API response, but it is null for all modules.

Known possible values for the marks are:

• 1-6 (numeric)
• bestanden
• B sehr gut
• D befriedigend
• E ausreichend

We need to figure out what the values for grade A, C and F are.

Expected behavior The information displayed by the extension is as expected.

Actual behavior

Every module has grade n/a:

The grade distribution calculation is broken:

Modules with grade F are counted towards the total resulting in wrong data in the graph:

Steps to Reproduce No special steps required, just open the webpage.

[ghost]

Hi there

I (guess) this was on accident. I'll have to check this internally. For the time being I reverted the behavior to as it was before.

Kind Regards Marco

[Lextum]

The grades are back, thanks @fafinsch :+1: I will close the issue for now.