Similar issue mentioned by MatthewButterfly:
/home/adminuser/fastcgi++/src/sockets.cpp: In member function ‘Fastcgipp::Socket Fastcgipp::SocketGroup::poll(bool)’:
/home/adminuser/fastcgi++/src/sockets.cpp:523:27: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
if(events == pollIn)
^
/home/adminuser/fastcgi++/src/sockets.cpp:538:27: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
if(events == pollIn)
This is on Centos 6.8 with devtoolset-4 and cmake3 installed.
I changed both instances to use if(events & pollIn) and compile worked.
I haven't tested the binary produced but I assume it'll work as you only want to check if the EPOLLIN bits are set in the events.
eddic
commented
6 years ago
Similar issue mentioned by MatthewButterfly: /home/adminuser/fastcgi++/src/sockets.cpp: In member function ‘Fastcgipp::Socket Fastcgipp::SocketGroup::poll(bool)’: /home/adminuser/fastcgi++/src/sockets.cpp:523:27: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] if(events == pollIn) ^ /home/adminuser/fastcgi++/src/sockets.cpp:538:27: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] if(events == pollIn)
This is on Centos 6.8 with devtoolset-4 and cmake3 installed.
I changed both instances to use if(events & pollIn) and compile worked. I haven't tested the binary produced but I assume it'll work as you only want to check if the EPOLLIN bits are set in the events.