search

eddie-2020 / my-portfolio-v0

0 stars 1 forks source link

Added accessibility to my portfolio #19

Closed eddie-2020 closed 3 years ago

eddie-2020 commented 3 years ago

In this project we did the following: Made sure there were no linter errors. Evaluated accessibility and made the necessary changes.

Page titles:no issue found

Image text alternatives Upon inspection, the alternative text was not descriptive enough the have been adjusted on the following lines. Social Media icons on Lines - 90, 95, 100, 105, 110 Social Media icons on Lines- , 288, 293, 298, 303,308

Text headings There were more than one h1 headings. As such we changed the headings to h2 and h4 and adjusted the CSS to match. The lines are reflected below. HTML Lines - 321,352,371

Color contrast There were some texts in the input(contact section) that can't be read by an elderly person so we added an hover to the input with background color of a darker blue and white text CSS Lines: 901, 902, 917, 918, 940, 944

Resize: No issues found.

Interaction: No issues found.

Moving content: No issues found.

Multimedia: No issues found.

The basic structure of the page: No issues found

eddie-2020 commented 3 years ago

How do I do this please

GzimAsani commented 3 years ago

How do I do this please

Take a step back and read this in the requirements --> Read

eddie-2020 commented 3 years ago

I have but still don't understand please can you explain

eddie-2020 commented 3 years ago

Is it just that i'm addressing?

GzimAsani commented 3 years ago

I have but still don't understand please can you explain

For this project, you should write a report(In your PR description) about the accessibility of your portfolio, based on the Easy Checks(you have it in your project description) – A First Review of Web Accessibility article, listing the accessibility points you checked and writing a conclusion summarizing the results of the evaluation.

eddie-2020 commented 3 years ago

okay so all i'm doing is highlighting the out right?

eddie-2020 commented 3 years ago

Please you may need to help me on this

eddie-2020 commented 3 years ago

This is my last review