Peer to peer code review - Githubissues

eddie-2020 / my-portfolio-v0

0 stars 1 forks source link

Peer to peer code review #4

Closed AnselemOdims closed 3 years ago

AnselemOdims commented 3 years ago

Below are the feedbacks and suggestions

The nav element would be more semantic if it is in the header element (line 25)
The hamburger menu would be more appropriate to be represented as a list item (line 31)
The li tags in the footer and form elements would be semantic if wrapped in a ul tag
The form should have a method
Form action should link to owner's page on the formspree website
It might not be adequate to use li in forms(suggestion)