eddie3 / gogrepo

Python-based tool for downloading all your GOG.com game and bonus collections to your local computer for full offline enjoyment.
481 stars 114 forks source link

Parentheses in filenames are not decoded #31

Closed Shiryou closed 5 years ago

Shiryou commented 6 years ago

The parentheses in the filenames have been encoded and need to be decoded.

JayB33 commented 6 years ago

I now get this when attempting to download.

05:03:43 | {faster_than_light}
05:03:43 | fatal...
Traceback (most recent call last):
  File "gogrepo.py", line 1167, in <module>
    main(process_argv(sys.argv))
  File "gogrepo.py", line 1147, in main
    cmd_download(args.savedir, args.skipextras, args.skipgames, args.skipids, args.dryrun, args.id)
  File "gogrepo.py", line 845, in cmd_download
    fd_info.write(html2text(item.changelog).strip())
  File "C:\Python27\lib\site-packages\html2text\__init__.py", line 937, in html2text
    return h.handle(html)
  File "C:\Python27\lib\site-packages\html2text\__init__.py", line 149, in handle
    self.feed(data)
  File "C:\Python27\lib\site-packages\html2text\__init__.py", line 146, in feed
    HTMLParser.HTMLParser.feed(self, data)
  File "C:\Python27\lib\HTMLParser.py", line 108, in feed
    self.goahead(0)
  File "C:\Python27\lib\HTMLParser.py", line 148, in goahead
    k = self.parse_starttag(i)
  File "C:\Python27\lib\HTMLParser.py", line 266, in parse_starttag
    % (rawdata[k:endpos][:20],))
  File "C:\Python27\lib\HTMLParser.py", line 115, in error
    raise HTMLParseError(message, self.getpos())
HTMLParseError: junk characters in start tag: u'\u201dBLUEPRINT_NAME\u201d>', at line 57, column 9
PS H:\gogrepo>

Fixed it by removing the offending string from the faster_than_light changelog entry in the manifest file.

Now I've noticed that I cannot connect to download from the GOG servers with my ISP provided IP and I have to connect to VPN to download. Has my IP been blocked for using gogrepo? That's the only thing I can think of.

Shiryou commented 6 years ago

Your IP is generally only blocked for 24 hours if I remember correctly. If you haven't already, try running the download off your VPN again.

JayB33 commented 6 years ago

The thing is I didn't do anything to warrant having my IP blocked. Gogrepo also freezes when fetching title data quite often, even when I successfully connect.