search

eddie3 / gogrepo

Python-based tool for downloading all your GOG.com game and bonus collections to your local computer for full offline enjoyment.
481 stars 114 forks source link

Decode parentheses in new filename format (fixes #31) #32

Closed Shiryou closed 5 years ago

Shiryou commented 6 years ago

Use the unquote function in urllib to decode the parentheses in GOG's new filename format.

Shiryou commented 6 years ago

@m-lohmann Did it have no effect at all? What OS are you running this on and on which version of Python? I'm a bit new to troubleshooting Python, so any further information would help.

m-lohmann commented 6 years ago

I made a fresh install of Windows 10 just 2 days ago and installed the latest version of Anaconda 2 (v5.1.0, Python 2.7) yesterday. As far as I’m aware gogrepo is not compatible with Python 3.

I applied your hotfix to my gorgepo.py file and ran gogrepo.py, resulting in the same undecoded parentheses in the file names.

Shiryou commented 6 years ago

Judging purely by a quick overview of the source, gogrepo.py should be compatible with Python 2 and Python 3. After running it with 3.4 it couldn't do a dry run of my downloads, so it seems you're right. I'll look into it a bit, but we may need to rely on someone with more experience to fix this.

m-lohmann commented 6 years ago

Could it be somehow related to this?

https://stackoverflow.com/questions/5139249/python-url-unquote-followed-by-unicode-decode

Shiryou commented 6 years ago

I'm in the desert for the weekend. See if the terminal encoding is set to UTF-8 or ANSI. https://superuser.com/a/1170658

If that doesn't solve it, try what you linked. Since I can't replicate it, I can't see if it solves the issue.

icemanx7 commented 6 years ago

@m-lohmann Did you run gogrepo.py update again so that the new file names get saved in the manifest?

m-lohmann commented 6 years ago

Thanks, @icemanx7! This solved the problem!

eddie3 commented 5 years ago

Thank you!