eddie3 / gogrepo

Python-based tool for downloading all your GOG.com game and bonus collections to your local computer for full offline enjoyment.
481 stars 114 forks source link

Error when trying to download OS specific files only to specified directory #34

Open buhund opened 6 years ago

buhund commented 6 years ago

Hello! Awesome utility, this! But I have encountered a little trouble trying to use it:

I've successfully downloaded files to an external disk, with default gogrepo.py, by running

cd /media/USER/DISK/Games/GOGrepo/gogrepo-master
./gogrepo update
./gogrepo download /media/USER/DISK/Games/GOGrepo/gogrepo-library/

I then found that it was only the Windows files being downloaded, which I assume is a result of line 113 in gogrepo.py:

DEFAULT_OS_LIST = ['windows']

I updated this to

DEFAULT_OS_LIST = ['windows', 'linux', 'mac']

I created directories for all OS', so as to have better overview

/media/USER/DISK/Games/GOGrepo/gogrepo-library-Windows
/media/USER/DISK/Games/GOGrepo/gogrepo-library-Linux
/media/USER/DISK/Games/GOGrepo/gogrepo-library-Mac

I've run both ./gogrepo.py update -os windows linux mac and ./gogrepo update (which should do the same now, due to my editing the gogrepo.py file) to get all OS' in the manifest. To download all Linux files to the -Linux directory, I ran ./gogrepo.py download -os linux /media/USER/DISK/Games/GOGrepo/gogrepo-library-Linux

However, I get an error when trying to download this way.

§ ./gogrepo.py download -os linux /media/USER/DISK/Games/GOGrepo/gogrepo-library-Linux/
usage: gogrepo.py [-h] [-v]
                  {login,update,download,import,backup,verify,clean} ...
gogrepo.py: error: unrecognized arguments: -os /media/USER/DISK/Games/GOGrepo/gogrepo-library-Linux/

What am I doing wrong?


Also, on that note, I'd like to suggest, if possible, to have the download automatically create directories based on operating system. E.g. (very crude, but you get the picture)

divinity_original_sin/
windows/
---setup_divinity_original_sin.exe
linux/
---setup_divinity_original_sin.sh
mac/
---setup_divinity_original_sin.dmg
eddie3 commented 1 year ago

Will add better support here in upcoming versions. Currently download does not support specifying an OS.