search

eddieantonio / perfection

Simple perfect hashing in Python
https://pypi.python.org/pypi/perfection
MIT License
13 stars 6 forks source link

Add support for Python 3 and Pickable hash #2

Closed tcalmant closed 7 years ago

tcalmant commented 7 years ago

This pull request adds support for Python 3 and is still compatible with Python 2.7+. It also add a pickable version of make_hash(), allowing the generated function to be broadcasted to a set of workers using pickle.

eddieantonio commented 7 years ago

Hey, thanks for the PR! I especially appreciate the Python 3 support!

With all that I've learned since the time I published this library to now, I'd probably write the pickleable hash a bit differently (like make the original picklable), but your solution is good.

I'll merge, add some tests, and update the package on PyPi.

eddieantonio commented 7 years ago

Hey @tcalmant. The updated version is available on PyPi:

pip install perfection==2.0.0
tcalmant commented 7 years ago

That's great ! Keep up the good work ;)