search

eddieguo-1128 / EEP153_Proj4

0 stars 0 forks source link

Code Review from Team Harvey Wiley #2

Open max177777 opened 1 year ago

max177777 commented 1 year ago

Hi Team T.W. Schultz,

You guys did a really good job of finding the nutritional deficiencies in Nigeria. The code is looking great to figure out your goals. It is really crazy job for converting all FDC units one by one.

One thing that you can double-check is the new spreadsheet with apikey = "lxD6lWLfAtFMmMogo98BZyZakAnjLIADqzEbiTjs". I assume that you create a your own version of the Nigeria datasheet. When I run the code in jupyter notebook. It occurs the FileNotFoundError. Meanwhile, I saw the code report many warings at result.graph_beta. We also meet a similar problem in our project. You can try to import warnings / warnings.filterwarnings("ignore") to ignore those warnings.

But overall, everything is great! And I like your graph about nutritional adequacy of household diet. Good job!

saaaallYao commented 1 year ago

Hi, Thanks for the great advice. We did create our own dataset for Nigeria because the original dataset is too messy to use in jupyter notebook. As for the warning one, I did not see any warnings when I run the code but I will definitely try the methods you mentioned:)

Team T.W. Schultz