eddiejaoude / eddiejaoude.github.com

Eddie Jaoude's website

http://eddiejaoude.io

MIT License

18 stars 8 forks source link

Solve Issue for Subscribe Box and Add Some CSS for Layout #107

Closed mr-vijaychauhan closed 4 years ago

mr-vijaychauhan commented 4 years ago

Description

First I remove from repeated ./horizontal-slim-10_7.css from <body>and include inside <head>. First I solved Issue for subscribed box overlap your character and not looking good and added css for layout and also added responsive css for mobile friendly. I added below screenshot so you understand very well.

*Note : Automatically format of index.html files because I am using VS CODE.

Fixes # (issue)

Solve Issue for Subscribe Box to overlap to your character image.

How Has This Been Tested?

I Upload below Screenshot of Before and After of index.html layout to Easily understanad what I did.

[ ] Before
[ ] After

eddiejaoude commented 4 years ago

Thank you @mr-vijaychauhan 👍 , looks like great improvements 🤓

Please can you do the formatting of the code in its own separate PR otherwise it is impossible to see the actual code changes.

mr-vijaychauhan commented 4 years ago

Thank you @mr-vijaychauhan 👍 , looks like great improvements 🤓

Please can you do the formatting of the code in its own separate PR otherwise it is impossible to see the actual code changes.

Thank You Sir to Replied. I did Changes as You Says. Please Check this Changes.

mr-vijaychauhan commented 4 years ago

Final Changes Done

eddiejaoude commented 4 years ago

Thank you 👍 .

The last word on a new line by itself looks a bit odd, can it be made wider or smaller?

The form breaks outside the card

mr-vijaychauhan commented 4 years ago

Hi Sir,

Description

I added bootstrap class for Subscribe box as well as Responsive Devices. I Fixed Problem Form breaks outside the card. I added Bootstrap Class For Your Content Justify. I tried to fix your content overlapping your character images.

[ ] Before (Without Justify Content)
[ ] After (With Justify Content and Fix Problem to Overlapping Character Image)
[ ] I cann't fix this Overlapping Problem in Mobile Device because Your Character Inside Your Body

I tried My best to Solve Your Problem.

Thanks !

eddiejaoude commented 4 years ago

This looks much better now 👍 . Thank you 🤓