eddielee394 / react-native-hindsighttrader

Basic stock market watchlist app built with React Native. Disclaimer: this thing is WIP status on an epic level. Checkout develop branch for latest stuff...
4 stars 7 forks source link

Watchlist chart performance issues #19

Open eddielee394 opened 4 years ago

eddielee394 commented 4 years ago

major performance issues being caused by the charts on the WatchlistSymbolList component. Charts are rendering while navigating to other screens, causing overall performance issues. Need to unmount the component (cleanup method in useEffect() maybe?) when navigating away.

Steps to reproduce:

Possible solutions Instead of rendering search component in a modal, we could navigate to the search screen and pop the watchlistsymbol screen from the stack which should unmount the component.

eddielee394 commented 4 years ago

@RaidNeferius this is an issue I was trying to resolve yesterday. I think the core problem is with the navigation architecture I implemented. The challenge is that I need to somehow optimize the rendering of the WatchlistSymbolList item charts in a way that's less performance intensive. Some things i've tried:

eddielee394 commented 4 years ago

flatlist optimizations https://link.medium.com/sCONnPoTo1