eddielee394 / react-native-hindsighttrader

Basic stock market watchlist app built with React Native. Disclaimer: this thing is WIP status on an epic level. Checkout develop branch for latest stuff...
4 stars 7 forks source link

refactor assets/images object to use named exports #24

Open eddielee394 opened 4 years ago

eddielee394 commented 4 years ago

Got it. Since I'll be removing those svg icons & instead use the react-native-svg-icon lib that's already installed, I'm going to hold off on implementing this suggestion.

Although, requiring each image as a property in the images object, would cause ALL of the required images to be stored in memory whenever images gets imported into a component - so I think this could still be refactored for performance reasons. I'll add this to a separate issue for later.

_Originally posted by @eddielee394 in https://github.com/eddielee394/react-native-hindsighttrader/pull/23/review_comment/create_