Improved feature: observe DOM changes instead of manually setting scrollactiveItems with setScrollactiveItems()

eddiemf / vue-scrollactive

Lightweight and simple to use vue component that highlights menu items as you scroll the page, also scrolling to target section when clicked.

MIT License

542 stars 70 forks source link

Closed nash403 closed 7 years ago

nash403 commented 7 years ago

add a DOM MutationObserver to listen for Node addition/deletion
console.warn instead of throwing error when the destination of the hash does not exist in the DOM yet as it may exist at some point in the future
update window.location.hash after the scroll animation (when scrollactive-item was clicked) so that we get kind of the same behavior as a normal link with a hash

eddiemf commented 7 years ago

Great additions, I really appreciate your help! I'm merging and soon updating the package.