eddiesigner / liebling

Beautiful and clean Ghost theme that is easy and comfortable to use. To get the latest version please head over the releases page 👉🏼
https://github.com/eddiesigner/liebling/releases
MIT License
1.27k stars 602 forks source link

Common styling, @tryghost/content-api as a dependency and french translation corrected #348

Closed clitzinger closed 3 years ago

clitzinger commented 3 years ago

Hi @eddiesigner,

I'd like to provide few updates for the liebling theme :

You can count on me for futur pull requests since i'm using the theme for my company. All the best and thanks for your work, Christophe

PS: This is my first pull request in a public project so don't hesitate to correct me if I'm doing something wrong

eddiesigner commented 3 years ago

Hi @clitzinger 👋🏻

I truly appreciate your work on this but I can just merge the changes related to the .editorconfig (which is great btw) file and the french translation 😅

I don't use the content-api module because it doesn't work on IE 11, at least the previous version, while the UMD build (the one I use currently) it does, that's why I would prefer using that version at least for now.

Also in general the double quotes are the preferred way in HTML files (or Handlebars files) and personally I prefer writing Javascript without ; at the end of each sentence, those are added by Laravel Mix anyway after the build.

It would be great if you can just keep the .editorconfig file and the french translation 😄 Thanks!

eddiesigner commented 3 years ago

Just to let you know that I just released a new version with some of your changes :)

I added the .editorconfig file and added the missing French translation. Thanks again for your contribution! I will close this MR now ;)