search

eddiesigner / liebling

Beautiful and clean Ghost theme that is easy and comfortable to use. To get the latest version please head over the releases page 👉🏼
https://github.com/eddiesigner/liebling/releases
MIT License
1.26k stars 598 forks source link

Theme fails Lighthouse test #351

Closed haavardnk closed 2 years ago

haavardnk commented 3 years ago

The theme fails the Lighthouse test in Chrome Dev Tools and Google Page Speed Insight. Happens both for the demo site and for my personal site using this theme. Other themes (tested Casper and Edition) does not have the same error. Error message: NO_LCP

To replicate: Run Lighthouse with chrome dev tools with device mobile for https://liebling.eduardogomez.io/ or https://developers.google.com/speed/pagespeed/insights/?url=https%3A%2F%2Fliebling.eduardogomez.io%2F&hl=en

ClassUnwind commented 3 years ago

Disabling the fade animation makes Lightouse pass on the LCP-test, at least on my end. Unsure of the reason why. Personally not a fan of it anyway, so it works out fine for me, though tracing and fixing the underlying reason would be cool.

eddiesigner commented 3 years ago

I'm not sure if this is really an issue with the theme itself, I mean, of course Google Page Speed Insight has a problem with the fade animation but is more likely that there is an issue with that tool, I google it and I found that unfortunately that tool has some similar known issues and those get fixed (or appear again) from one version to another. In the future I will try to replace the current library that the theme uses for the fade animation to see if the problem disappears.

eddiesigner commented 2 years ago

I'm closing this issue since this has been fixed in the latest version 👍

The problem was caused by the AOS library, now the theme uses css-only animations instead in order to fix the issue.