search

eddiesigner / liebling

Beautiful and clean Ghost theme that is easy and comfortable to use. To get the latest version please head over the releases page 👉🏼
https://github.com/eddiesigner/liebling/releases
MIT License
1.26k stars 598 forks source link

The progress indicator shows wrong progress if the post contains image. #411

Closed Fabhi closed 2 years ago

Fabhi commented 2 years ago

The circular progress indicator shows 100% progress before the post is even finished if the post contains images. I think the images have not been taken into accout for calculating the progress.

eddiesigner commented 2 years ago

Can you provide a link?

The theme tries to calculate the progress when the load event is triggered, in theory that should happen when the whole page has loaded, including all dependent resources such as stylesheets and images.

Of course the progress is just an estimate, in some cases images or iframes that take longer to be fully loaded are not taking into account but that depends of your Internet speed or the size of the images.

For me it works correctly all the time in the demo website.

eddiesigner commented 2 years ago

I will close this issue for now due inactivity, please feel free to comment again if necessary.