search

eddiesigner / liebling

Beautiful and clean Ghost theme that is easy and comfortable to use. To get the latest version please head over the releases page 👉🏼
https://github.com/eddiesigner/liebling/releases
MIT License
1.26k stars 598 forks source link

Locale: In both light and dark mode the tooltip says "Toggle dark mode" #418

Closed begonaalvarezd closed 2 years ago

begonaalvarezd commented 2 years ago

Not a big deal, just a suggestion 🙏🏼

Perhaps would be better using switch to dark mode switch to light mode or something like that? Souce

image image

eddiesigner commented 2 years ago

I agree that it would be a better translation, the problem is that we can't change the translations based on the theme appearance, that's why I tried to use a translation that could work in both situations. Do you have a suggestion that could work well? 😄

ghost commented 2 years ago

Maybe just simply "Toggle Light/Dark"?

ArjoDas commented 2 years ago

or just "Light/Dark"?

eddiesigner commented 2 years ago

Yeah, "Toggle Light/Dark" sounds good, might be even better if we say "Toggle light/dark mode".

I will close this issue since I already updated the translation in the English locale file (and Spanish).