search

eddiesigner / liebling

Beautiful and clean Ghost theme that is easy and comfortable to use. To get the latest version please head over the releases page 👉🏼
https://github.com/eddiesigner/liebling/releases
MIT License
1.25k stars 597 forks source link

Added RSS File for Yandex Turbo Pages and Some Dynamic Content Code #452

Closed navaneethred closed 2 years ago

navaneethred commented 2 years ago

This file is an RSS file with the necessary properties for Yandex Turbo Pages. You can add this in the Yandex Webmaster under the turbo pages section. Turbo pages enable small snippets of your content to be shown on Yandex search results and it decreases load time on mobile devices. https://yandex.com/dev/turbo/

You can access this file at: https://<SITE-URL>/yandex/rss/

navaneethred commented 2 years ago

Also need to add:

routes:
  /yandex/rss/:
    template: yandex/rss
    content_type: text/xml

in the routes.yaml file.

navaneethred commented 2 years ago

The second commit includes changes to the posts.hbs file in order to show the subscription form to only those who have not signed in. It also includes changes to the partials/navigation.hbs file this allows the site to show 'Account' as the tag instead of 'Sign Up' when a user is signed in.

eddiesigner commented 2 years ago

Hey, first of all thank you for your contribution and sorry for the late response 😅

I'm not sure if this should be part of the theme by default though, from my point of view this can be instead some sort of tutorial or article that can be described in the Wiki.

Also, since this theme doesn't implement pages for memberships like the Account or Signup pages, I wouldn't integrate that change either, I think that change is more relevant for your use case.

Hope my comments make sense to you and thanks again 😄, however I'm afraid that I can't merge this PR, sorry.