search

eddiesigner / liebling

Beautiful and clean Ghost theme that is easy and comfortable to use. To get the latest version please head over the releases page 👉🏼
https://github.com/eddiesigner/liebling/releases
MIT License
1.25k stars 597 forks source link

Support native search? #462

Closed shincurry closed 2 years ago

shincurry commented 2 years ago

Ghost Official introduced Native Search recently.

https://ghost.org/changelog/search/

Adding Search to a Ghost site is easy, and can be done in two ways:

Add a #/search link to your site navigation in Ghost Admin, and you'll have a clickable navigation link that opens the search interface. Read more in our help docs. Add a data-ghost-search attribute to any element in your theme (a 🔎 icon, perhaps?), and you'll have a clickable button to open the search interface. Read more in our developer docs.

just5ky commented 2 years ago

https://github.com/eddiesigner/liebling/wiki/How-to-enable-search

@shincurry

monster1612 commented 2 years ago

https://github.com/eddiesigner/liebling/wiki/How-to-enable-search

that solution is the pre-5.x approach to enabling search in the Liebling theme, and isn't quite as powerful as the native search feature available in Ghost now.

one possible workaround is to add a link in the header with the URL #/search, but a more native solution (bonus points if it can bind to Ctrl/Cmd + K) would be ideal.

just5ky commented 2 years ago

Ok, I see what you mean, the new search thingy is so much better and fast I added it to Custom CTA image

Recording 2022-07-27 at 15 14 32

magicgg91 commented 2 years ago

@Just5KY yes that's a solution, but it's not best integration we can have. Search button on top right is still there with different search algorithm.

I would expect to have this button using builtin Ghost search feature.

FAFDK commented 2 years ago

How about the translation of the search string? Where is that located? : " Search posts, tags and authors". Testing a fresh Danish da.json now.