eddiesigner / sketch-dark-mode

Generate a dark mode version of any Sketch document, the right way.
https://sketch-dark-mode.eduardogomez.io
62 stars 7 forks source link

'Creating Color Palette' doesn't work. #13

Closed Real-Moomin closed 3 years ago

Real-Moomin commented 3 years ago

Hello, I'm Theo. I'm using 'Sketch Dark Mode' Plugin in the newest version(Sketch 69).

In this version, 'Creating Color Palette' doesn't work anymore though I assigned unique names to every single color. I guess it happens after Sketch started offering new Symbol(Component) UI.

image

image

image

Please check out screenshots. I tried to test with new Sketch file. Thanks.

eddiesigner commented 3 years ago

Hi, thanks for the feedback!

From the docs:

Sketch 69 introduces a new Color Variables feature. Color Variables replace the previously existing colors object in Document with a new one: swatches. It is an array of Color Variables, internally referred to as Swatches, which you can modify directly.

Apparently in the last version they replaced the colors object that this plugin uses. I will work on a new version that supports the recent changes in their API 👍

Real-Moomin commented 3 years ago

@eddiesigner Sounds great. I hope that everyone can use this plugin again as soon as possible ! 👍 Have a nice day!

Real-Moomin commented 3 years ago

And I wonder when will you distribute a hot-fix(or a new version) for plugin. Being currently working on Dark Mode Project on our product, our team is waiting for issue fixed.

Thanks again. I really appreciate. 😄

eddiesigner commented 3 years ago

I'm not sure, I hope I can release a new version next week or so.

Real-Moomin commented 3 years ago

Got it ! Thank you, and have a nice day ! 😁

eddiesigner commented 3 years ago

Version 2.5.0 supports Color Variables 😃

More details here: https://github.com/eddiesigner/sketch-dark-mode/wiki/How-to-use-Sketch-Dark-Mode

Real-Moomin commented 3 years ago

@eddiesigner , Thank you so much! 😊