search

eddiesigner / sketch-dark-mode

Generate a dark mode version of any Sketch document, the right way.
https://sketch-dark-mode.eduardogomez.io
62 stars 7 forks source link

Issues with updated colors #19

Closed g48oo closed 3 years ago

g48oo commented 3 years ago

Hey this plugin is slick, and something I'd like to use for an upcoming project I've got. The only issue I see is this: when I update a color from my library, it doesn't update in the manage palette modal. I couldn't even relink it. It's like the manage palette was stuck in the time that I first opened it, and any changes would require a manual override of those colors.

Is there anyway the plugin could update the left-side color options?

eddiesigner commented 3 years ago

Hey, I couldn't reproduce this issue. I updated a color in some library and then save it. After that I opened the color palette window and the color was already updated.

The plugin doesn't save your library colors, it only saves the dark variations, that means every time you open the color palette window the plugin loads your libraries from scratch so the new possible changes are already there.

Did you save your library file before open the plugin window? If you library comes from the cloud, you might need to update it before opening the plugin.

What version of Sketch are you using? Are you using Color Variables or Color Assets in your library?

g48oo commented 3 years ago

Hey Eddie,

Awesome - yeah you're right. Thanks for helping me out with that one.

One more question / request. Is there any way that the colors could show up in alphabetical order? Here's what I see when I use the plugin:

Thanks, g

On Tue, Dec 29, 2020 at 9:03 AM Eduardo Gómez notifications@github.com wrote:

Hey, I couldn't reproduce this issue. I updated a color in some library and then save it. After that I opened the color palette window and the color was already updated.

The plugin doesn't save your library colors, it only saves the dark variations, that means every time you open the color palette window the plugin loads your libraries from scratch so the new possible changes are already there.

Did you save your library file before open the plugin window? If you library comes from the cloud, you might need to update it before opening the plugin.

What version of Sketch are you using? Are you using Color Variables or Color Assets in your library?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/eddiesigner/sketch-dark-mode/issues/19#issuecomment-752085873, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASJG4ACS4XKH6QBHGITES6DSXHOTTANCNFSM4VMNCM6Q .

eddiesigner commented 3 years ago

Hey, I just released version 3.1.0 which sorts the colors in alphabetical order ;)

g48oo commented 3 years ago

That’s awesome! Thanks for the heads up, I really appreciate it.

Also, I showed your plugin to my design team and they were all really excited and impressed.

If the teams all decides to download, I will definitely make an appeal to make individual purchases and bill accordingly.

On Tue, Jan 26, 2021 at 3:49 PM Eduardo Gómez notifications@github.com wrote:

Closed #19 https://github.com/eddiesigner/sketch-dark-mode/issues/19.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/eddiesigner/sketch-dark-mode/issues/19#event-4252674608, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASJG4ACCU2G3NCKYTVKAUJDS34TFDANCNFSM4VMNCM6Q .

-- Gabriella Cook User Experience + Visual Design www.gabriellacook.com 206-949-2364

eddiesigner commented 3 years ago

Thank you for the kind works, glad to hear that! 🙏🏻

Btw, The latest release also features transparency support ;)