eddiesigner / sketch-dark-mode

Generate a dark mode version of any Sketch document, the right way.
https://sketch-dark-mode.eduardogomez.io
62 stars 7 forks source link

Strange behavior after installing #34

Open chrtz opened 2 years ago

chrtz commented 2 years ago

After installing the plugin via Sketchrunner, I tried do manage the color palette. But as soon as the modal window opens, a download dialog for downloading a iOS 15 Sketch library opens. Why?

eddiesigner commented 2 years ago

Would you mind to share more info? What version of Sketch are you using? What macOS version are you using?

Would you mind also share a screenshot?

The plugin doesn't do anything with that library, I actually wonder if that's really related to the plugin, maybe is something that Sketch is doing by itself or maybe another plugin 🤔

Would you mind also install the plugin manually?

The only thing that the plugin does is to get the libraries like this:

libraries = require('sketch/dom').getLibraries()

I don't see how that line will display a dialog like the one you're describing, that call only returns an array.

chrtz commented 2 years ago

Thanks for your reply and investigation. I'll provide any further information upcoming week.

chrtz commented 2 years ago

Used Sketch version: 79 (133334) macOS version: macOS Big Sur 11.6.1

I just downloaded your latest plugin release via GitHub, as soon as I start the plugin and run the manage palette function, the install Apple-Sketch-Library-iOS-15.dmg dialog window appears. It doesn't seem to matter if it's installed directly or via Sketch runner.

PXL_20211108_065213247

It doesn't appear while using any other plugin. The behavior also disappears as soon as I uninstall your plugin.

I haven't installed any external libraries (like the iOS one).

(Please ignore the fact, that I actually took a photo of my screen, as just doing an actual screenshot)

eddiesigner commented 2 years ago

Hi, thanks for the follow up, this is strange indeed. Maybe Sketch wants you to install that library when the following line is executed (for some unknown reason):

libraries = require('sketch/dom').getLibraries()

Although I haven't found any documentation about it.

That library is an official library from Sketch, I guess you can just install it in order to make that message disappear 🤔