codepathreview
commented
8 years ago Decent submission, consider adding more challenging bonus stories. A few notes after checking out the code:
- Good to see you were able to format the timestamp cleanly
- Good to see you refreshed the timeline after composing a new tweet
- Nice touch with the character count being displayed while the user composes a tweet
- Nice to see you used a
SwipeRefreshLayoutlibrary for easy timeline refreshes - Consider adding progress bars to your app whenever a network request goes out
- Consider adding
ActiveAndroidto the Tweet and User. See the persistence guide and this other guide for more details. - Consider better organizing your source files
Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.
My app is complete, please review. /cc @codepathreview @codepath
Due to the travel plan(Planned half year ago) I had this week, I haven't got time to finish some of the optional stories. This is my initial submission. I'll keep working on it.
I spent some time trying to put in a Theme title bar for my new tweet fragment. However, after the tool bar theme set in the styles.xml, my title bar in new tweet fragment went away. Could you point me to a note that describe how the Theme works? For the two styles.xml (regular and v14), should we put all of our Themes and settings in the v14 one unless we want to target API 14 or below? should we put the general themes in both?
Thank you.