[Android Bootcamp] Project 4: Improve Simple Twitter Client - Ready for Review

[eddietseng]

My app is complete, please review. /cc @codepathreview @codepath

Also, I have questions as listed below.

1. Is there a general rule for the location of wrapping the progress indicator? I wrapped around each client.getBlablabla(). Is this the right place to do? (I tried to implement the progress dialog, but it didn't work properly.)
2. For the check internet availability, what's the best practice? check before each call? (In this implementation, I saved the User data onCreate of the TimelineActivity and pass around that user data. When testing the network checks, I faced an issue when the network is back. By clicking the user profile icon, I did a check to see if the userData == null. If yes and the network is available, I try to retrieve the user data again. However, the data did not set before the intent is launch. Is this because of the time to retrieve data? Should I do a timer to check the userData again? Is this the best practice?)

Thank you for your time.

[codepathreview]

1. Use a ProgressBar and toggle it with the content during onSuccess response.
2. Best practice would be to complete getting the required data and only then proceed to next step. Make a synchronous call if needed.

[codepathreview]

Decent submission, but try to add more optional features if you get time. A few notes after checking out the code:

• Correctly communicated between Fragment and Activity for User Profile
• Nice to see you used the ViewPager to properly setup the tabs!
• For the sliding tabs, try styling the tabs to customize their appearance.
• Consider adding progress bars to your app whenever a network request goes out
• Consider adding local persistence of tweets by using ActiveAndroid in the model objects. See the persistence guide and this other guide for more details.
• For a future exercise, challenge yourself to move even more of the logic into the base Fragment class and out of the extension timeline fragments. For example, the scroll listener could be set in the base class and then the onLoadMore could call an abstract method which is defined separately in the extended class. This approach could be used to move almost all the logic into the base except for certain key abstract methods.
• In the future, definitely consider additional polish for the UI by reviewing the cloning a screen tutorial and Q&A and the drawables guide
• Try to implement more optional features so that you will get to play with more widgets and understand complexities involved

Here's a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

This week (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 and week 7 we will be covering a few important intermediate topics such as more about styling and animation as well as testing.

Following the bootcamp, we are going to have a public demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group projects that you all have built. We are going to help however we can over the next few weeks to get the team project apps in shape for that.