remove extraneous check - fixes #126 [semver:patch]

eddiewebb / circleci-queue

CircleCI orb to block/queue jobs to enforce max concurrency limits

MIT License

74 stars 75 forks source link

remove extraneous check - fixes #126 [semver:patch] #127

Closed eddiewebb closed 6 months ago

eddiewebb commented 6 months ago

Checklist

[ ] All new jobs, commands, executors, parameters have descriptions
[ ] Examples have been added for any significant new features
[ ] README has been updated, if necessary

Motivation, issues

Fixes #126

Description

Logic uses CIRCLE_BRANCH anyway. THe check was needlessly aggressive to make sure underlying orb properly setup script environment.

eddiewebb commented 6 months ago

BotComment: Development version of orb available for manual validation - Once an orb is created it cannot be deleted. Orbs are semver compliant, and each published version is immutable. Publicly released orbs are potential dependencies for other projects. Therefore, allowing orb deletion would make users susceptible to unexpected loss of functionality. eddiewebb/queue@dev:553

eddiewebb commented 6 months ago

BotComment: Production version of orb available for use - Once an orb is created it cannot be deleted. Orbs are semver compliant, and each published version is immutable. Publicly released orbs are potential dependencies for other projects. Therefore, allowing orb deletion would make users susceptible to unexpected loss of functionality. eddiewebb/queue@3.1.3