search

eddiewebb / circleci-queue

CircleCI orb to block/queue jobs to enforce max concurrency limits
MIT License
74 stars 75 forks source link

accept strings as pipeline IDs #129

Closed joaquincasares closed 4 months ago

joaquincasares commented 4 months ago

Checklist

Motivation, issues

I'm attempting to use epoch time as the value for my-pipeline. Each close attempt I've made has failed on a similar error:

Type error for argument my-pipeline: expected type: integer, actual value: "$EPOCH_TIME" (type string)

Description

I've checked loop.bash and there's nothing that assume my-pipeline is an integer, so this change shouldn't be an issue.

P.S. Thanks for creating a necessary feature that should have been packaged with CircleCI!! This will be the second time I use this in production. :)

eddiewebb commented 4 months ago

Must be the pipeline id used by circle CI. See the examples.

On Tue, May 21, 2024, 8:31 PM Joaquin Casares @.***> wrote:

Checklist

  • All new jobs, commands, executors, parameters have descriptions
  • Examples have been added for any significant new features
  • README has been updated, if necessary

Motivation, issues

I'm attempting to use epoch time as the value for my-pipeline. Each close attempt I've made has failed on a similar error:

Type error for argument my-pipeline: expected type: integer, actual value: "$EPOCH_TIME" (type string)

Description

I've checked loop.bash and there's nothing that assume my-pipeline is an integer, so this change shouldn't be an issue.

P.S. Thanks for creating a necessary feature that should have been packaged with CircleCI!! This will be the second time I use this in production. :)

You can view, comment on, or merge this pull request online at:

https://github.com/eddiewebb/circleci-queue/pull/129 Commit Summary

File Changes

(2 files https://github.com/eddiewebb/circleci-queue/pull/129/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/eddiewebb/circleci-queue/pull/129, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIEWSSDH6UP6BZ75WZQHPTZDPRPZAVCNFSM6AAAAABICS3GFWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMYDSMZTG44DOMQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

joaquincasares commented 4 months ago

I looked deeper into the code today and saw what you were doing with jq at the CircleCI level.

Withdrawing this PR. Thanks again tho! :)