search

eddiewebb / circleci-queue

CircleCI orb to block/queue jobs to enforce max concurrency limits
MIT License
74 stars 75 forks source link

Pass block-workflow parameter to until_front_of_line step [semver:patch] #50

Closed mu-bro closed 4 years ago

mu-bro commented 4 years ago

Motivation, issues

block-workflow parameter is not passed from queue/block_workflow job to until_front_of_line step, therefore block-workflow is always set to 'false'.

eddiewebb commented 4 years ago

Can you merge in latest from master?

eddiewebb commented 4 years ago

bors try

bors[bot] commented 4 years ago

try

Merge conflict

eddiewebb commented 4 years ago

bors try

eddiewebb commented 4 years ago

BotComment: Development version of orb available for manual validation - eddiewebb/queue@dev:50

eddiewebb commented 4 years ago

I added some tests (bats is a little cryptic, i dont expect folks to take that ramp), assuming these run through it LGTM!

Thanks for catching this.

eddiewebb commented 4 years ago

bors merge

eddiewebb commented 4 years ago

BotComment: Development version of orb available for manual validation - eddiewebb/queue@dev:50

eddiewebb commented 4 years ago

BotComment: Production version of orb available for use - eddiewebb/queue@1.4.1

bors[bot] commented 4 years ago

Build succeeded

bors[bot] commented 4 years ago

try

Build succeeded