search

eddiewebb / circleci-queue

CircleCI orb to block/queue jobs to enforce max concurrency limits
MIT License
74 stars 75 forks source link

"Ghost" jobs (with SSH session open) keeps queue always blocked #61

Closed pacoard closed 3 years ago

pacoard commented 3 years ago

Orb version

What happened

Trying out this orb for the first time, for some reason I see that, within my builds, the number 380 was skipped (probs a CircleCI bug? ), and this number is detected by the queue orb as if it was still running, rendering the next deployments useless since they THINK there's a build still running.

All branches and everyone's pipelines are selected, so there are no filters that could hide that missing 380 image

image

image

Expected behavior

380 doesn't exist or it is not running, therefore the queue shouldn't be blocked!

I wonder if this is an uncaught error that could be solved from this orb's end

pacoard commented 3 years ago

UPDATE

Turns out that the job 380 was stuck because I rerun it with an SSH session, which keeps the job running for 2h if you don't exit the SSH session.

Leaving this issue open anyway, but I'll change the title to account for this

eddiewebb commented 3 years ago

Thanks for reporting @pacoard

To wait for SSH jobs feels valid to me since SSH jobs still perform all steps, which could clash with other non-ssh jobs running the same tasks.