fix(urlencode): urlencode CIRCLE_BRANCH [semver:patch]

[andrew-barnett]

Motivation, issues

The CircleCI API (started?) requiring urlencoded branch names, otherwise the calls were returning empty results. This caused the queue to never succeed. This fix urlencodes the branch name. See #89

Description

add urlencode function and run ${CIRCLE_BRANCH} through it while building branch-specific API url

fixes #89

[eddiewebb]

bors try

[eddiewebb]

BotComment: Development version of orb available for manual validation - eddiewebb/queue@dev:417

[bors[bot]]

try

Build succeeded:

• build-deploy

[eddiewebb]

bors delegate+

[bors[bot]]

:v: andrew-barnett can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

[eddiewebb]

@andrew-barnett - please see my comment/concern about portability. Assuming it works across those 3 shells I have delegated review permission, so you can just add a comment here of bors merge

[andrew-barnett]

@eddiewebb I'm not finding your comment about which shells to check. Can you post here?

[eddiewebb]

I'm sorry Andrew it was stuck pending, submitted it.

[andrew-barnett]

@andrew-barnett - please see my comment/concern about portability. Assuming it works across those 3 shells I have delegated review permission, so you can just add a comment here of bors merge

@eddiewebb - It didn't work on zsh, so updated the code to make it portable. Passing it back for review.

[andrew-barnett]

bors try

[eddiewebb]

BotComment: Development version of orb available for manual validation - eddiewebb/queue@dev:421

[bors[bot]]

try

Build succeeded:

• build-deploy

[andrew-barnett]

bors r+

[eddiewebb]

BotComment: Development version of orb available for manual validation - eddiewebb/queue@dev:424

[bors[bot]]

Build failed:

• build-deploy

[eddiewebb]

bors merge

[bors[bot]]

Merge conflict.

[eddiewebb]

( ialways get the magic PR title wrong, added a sanity check and changelog)

Version 1.8.2 and soon 1.8.3 wil include this fix, thanks @andrew-barnett !

[eddiewebb]

bors merge

[eddiewebb]

BotComment: Development version of orb available for manual validation - eddiewebb/queue@dev:431

[eddiewebb]

BotComment: Production version of orb available for use - eddiewebb/queue@1.8.4

[bors[bot]]

Build succeeded:

• build-deploy