search

eddiexing / f1-3-c2p1-colmar-academy

0 stars 0 forks source link

long selector chains #4

Open rimmesbe opened 6 years ago

rimmesbe commented 6 years ago

You are chaining together a lot of selectors here. The problem with doing that is your stylesheet gets very rigid and will break on any type of design change or reorganization of the site (which is common in webpages). You are better off keeping the chains short and creating new class components if you need to.

https://github.com/eddiexxx/f1-3-c2p1-colmar-academy/blob/master/Colmar%20Academy/resources/css/style.css#L240

eddiexing commented 6 years ago

Yes, you are right. I should replace the selector: .information .gallery-item .image img by .information img with section name and item name.